base-layer/commandkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Separate show cancellation from rendering errors

Browse Source
This commit is contained in:
Eric Rakestraw
2026-11-07 15:42:22 +00:00
parent 552b91c0a2
commit 4346b840db
4 changed files with 56 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
docs/roadmap/audit/catalog.md
View File

@@ -1,6 +1,6 @@
# Consolidated audit catalog
Status: **23 distinct open findings: one P2 and 22 P3**, consolidated from 30
Status: **22 distinct open findings: 22 P3**, consolidated from 30
numbered entries in seven audit documents. Reviewed audit state:
`db732e3a1de55c844f77870e1c6db683c2685d5d`.
@@ -122,6 +122,11 @@ Also noted in the [documentation cross-references](13-documentation.md#previousl
## F05 — P2: Configuration-show cancellation is also recorded as a rendering failure
**Complete.** A cancellation checkpoint stops buffered show preparation without
reporting cancellation as a render error. A regression failed before the fix;
focused tests now verify no partial output, cancellation identity, and retained
native rendering errors when both occur.
ckconfig checks cancellation during buffered show preparation inside the
`RenderOutput` callback. Returning that cancellation from the renderer records
both the correct operation cause and a false presentation failure, conflating

8
docs/roadmap/implementation.md
View File

@@ -1,6 +1,6 @@
# Audit remediation implementation plan
Status: in progress; Stages 1–4 complete.
Status: in progress; Stages 1–5 complete.
Baseline: `d492c7747175c01a53261206c2b4356e53453621`. Before this sprint,
intervening changes recorded decisions and retired the completed older
@@ -223,6 +223,12 @@ Complete when empty successful acquisition cannot masquerade as prepared preview
## Stage 5 — Separate show preparation cancellation from rendering failures
**Complete.** Buffered show preparation carries cancellation outside managed
rendering without emitting the incomplete report. The two-scope regression
failed against the original behavior and now passes, including simultaneous
native rendering failure; focused show, buffered cancellation and write-failure
tests passed in the offline aligned Go 1.27.0 workspace with `-mod=readonly`.
Findings: F05. Source: ckconfig `show.go`; reference `operations.go`'s
renderPreparedConfigReport checkpoint pattern.