Preserve terminal values during result lookup

This commit is contained in:
2026-11-21 12:00:29 +00:00
parent bcee3f866f
commit ed5d57d061
4 changed files with 86 additions and 11 deletions

View File

@@ -7,11 +7,18 @@ Scope: the nine stages of [implementation.md](implementation.md), the settled
No implementation changes were made during these reviews. Findings 1–2 come
from the correctness/architecture review; finding 3 comes from the subsequent
algorithmic review. All findings below remain open.
algorithmic review. Completion notes below track remediation after those reviews.
## 1. Terminal availability still depends on recursive schema validity
**Priority:** P2. **Status:** Open. **Plan stages:** 1–2.
**Priority:** P2. **Status:** Complete. **Plan stages:** 1–2.
**Completion:** lookup descriptors now describe only the containing shape and
necessary inline bindings; ordinary children remain opaque until navigation
continues. Added public regressions for map/slice/array terminals, post-load
dynamic children and siblings, and continued rejection of ambiguous navigation
and invalid load schemas. The regression failed before the fix. Focused tests,
`./scripts/check.sh`, and `go test -race ./...` passed with Go 1.27.4.
**Relevant code:** [ResultValue](../../internal/engine/result_value.go), especially
its descriptor construction at line 33; the recursive map/slice/array and struct