From dd760d84e0299f9612c0d4c18fc9a76837d2a7ff Mon Sep 17 00:00:00 2001 From: Eric Rakestraw Date: Sun, 4 Oct 2026 14:00:55 +0000 Subject: [PATCH] Compare inherited effective pipeline values --- internal/config/artifact_families_test.go | 106 ++++++++++++++++++++++ 1 file changed, 106 insertions(+) diff --git a/internal/config/artifact_families_test.go b/internal/config/artifact_families_test.go index d5c420a..83e7784 100644 --- a/internal/config/artifact_families_test.go +++ b/internal/config/artifact_families_test.go @@ -407,6 +407,112 @@ whisperx: } } +func TestInheritedAndExpandedConfigurationsHaveEqualEffectiveSemantics(t *testing.T) { + load := func(t *testing.T, expanded bool) *Config { + t.Helper() + dir := t.TempDir() + writePartyResolutionFile(t, filepath.Join(dir, "party.yml"), `schema_version: narratio.party.v1 +characters: + alice: + player: {name: Alice Player} + character: + name: Alice + classes: [{name: wizard}] +`) + + pipeline := `configkit: + imports: + - path: definitions/parent.yml + - path: definitions/child.yml +whisperx: + transcribe_url: https://transcription.example.test/transcribe +` + if expanded { + pipeline = `whisperx: + transcribe_url: https://transcription.example.test/transcribe +scriptorium: + artifacts: + base: + enabled: false + prompt_id: dnd.summary + profile_id: production + output_path: artifacts/base.md + render_debug: false + summary: + enabled: true + prompt_id: dnd.summary + profile_id: production + output_path: artifacts/summary.md + render_debug: false + artifact_families: + character_summary: + enabled: true + for_each: party.characters + prompt_id: dnd.character_summary + profile_id: production + output_path_pattern: artifacts/characters/{character_id}/summary.md + character_notes: + enabled: true + for_each: party.characters + prompt_id: dnd.character_summary + profile_id: production + output_path_pattern: artifacts/characters/{character_id}/notes.md +` + } else { + writePipelineFixture(t, dir, "definitions/parent.yml", `scriptorium: + artifacts: + base: + enabled: false + prompt_id: dnd.summary + profile_id: production + output_path: artifacts/base.md + render_debug: false + artifact_families: + character_summary: + enabled: true + for_each: party.characters + prompt_id: dnd.character_summary + profile_id: production + output_path_pattern: artifacts/characters/{character_id}/summary.md +`) + writePipelineFixture(t, dir, "definitions/child.yml", `scriptorium: + artifacts: + summary: + extends: base + enabled: true + output_path: artifacts/summary.md + artifact_families: + character_notes: + extends: character_summary + output_path_pattern: artifacts/characters/{character_id}/notes.md +`) + } + pipelinePath, campaignPath, sessionPath := writeArtifactFamilyConfig(t, dir, pipeline) + cfg, err := LoadWithSessionOptions(pipelinePath, campaignPath, sessionPath, SessionLoadOptions{}) + if err != nil { + t.Fatalf("LoadWithSessionOptions(expanded=%t): %v", expanded, err) + } + return cfg + } + + inherited := load(t, false) + expanded := load(t, true) + inheritedValues, err := EffectivePipelineValues(inherited.Pipeline) + if err != nil { + t.Fatal(err) + } + expandedValues, err := EffectivePipelineValues(expanded.Pipeline) + if err != nil { + t.Fatal(err) + } + if !reflect.DeepEqual(inheritedValues, expandedValues) { + t.Fatalf("inherited and expanded effective values differ:\ninherited=%#v\nexpanded=%#v", inheritedValues, expandedValues) + } + if inheritedDigest, expandedDigest := EffectivePipelineDigest(inherited.Pipeline), EffectivePipelineDigest(expanded.Pipeline); inheritedDigest != expandedDigest { + t.Fatalf("inherited and expanded digests differ: %q != %q", inheritedDigest, expandedDigest) + } +} + func TestExplicitFamilyMemberPublishDestinationResolution(t *testing.T) { dir := t.TempDir() writePartyResolutionFile(t, filepath.Join(dir, "party.yml"), `schema_version: narratio.party.v1