package app import ( "bytes" "context" "os" "path/filepath" "strings" "testing" "gitea.maximumdirect.net/eric/narratio/internal/config" "go.maximumdirect.net/commandkit" configkit "go.maximumdirect.net/configkit" ) func TestConfigurationComparisonUsesIndependentRootDefaults(t *testing.T) { left, _, _ := writeValidConfigFiles(t, t.TempDir()) right, _, _ := writeValidConfigFiles(t, t.TempDir()) search := configkit.SearchPaths(right) loads, bootstrap := 0, 0 app, err := newApplication(commandDependencies{ pipelineSearch: &search, loadPipelineConfig: func(path string, options config.PipelineLoadOptions) (*config.PipelineConfig, error) { loads++ return config.LoadPipelineWithOptions(path, options) }, loadSecretsDir: func(string) (*configkit.SecretsReport, error) { bootstrap++; return nil, nil }, }, executePlan) if err != nil { t.Fatal(err) } var out, diagnostic bytes.Buffer outcome := app.Execute(context.Background(), []string{"config", "diff", "--details", "--config", left, "--check", "--format", "json", "--secrets-dir", t.TempDir()}, commandkit.Streams{Out: &out, Err: &diagnostic}) if outcome.Status != 3 || loads != 2 || bootstrap != 1 || !strings.Contains(out.String(), "/workspace/root") { t.Fatalf("status=%d loads=%d bootstrap=%d output=%s diagnostics=%s", outcome.Status, loads, bootstrap, out.String(), diagnostic.String()) } } func TestConfigurationComparisonAndShowApplyOnlyAppOverrides(t *testing.T) { pipeline, campaign, _ := writeValidConfigFiles(t, t.TempDir()) before, err := os.ReadFile(pipeline) if err != nil { t.Fatal(err) } var out, diagnostic bytes.Buffer args := []string{"config", "diff", "--details", "--config", pipeline, "--against-config", pipeline, "--set", `/whisperx/language="fr"`, "--against-set", `/whisperx/language="de"`, "--check", "--format", "json"} outcome := Execute(context.Background(), args, commandkit.Streams{Out: &out, Err: &diagnostic}) if outcome.Status != 3 || !strings.Contains(out.String(), "/whisperx/language") || !strings.Contains(out.String(), "fr") || !strings.Contains(out.String(), "de") { t.Fatalf("status=%d output=%s diagnostics=%s", outcome.Status, out.String(), diagnostic.String()) } shown := nativeInspectionForTest(t, []string{"config", "show", "--config", pipeline, "--set", `/whisperx/language="fr"`, "--path", "/whisperx/language", "--format", "json"}) if !strings.Contains(shown, "fr") { t.Fatalf("override not applied: %s", shown) } shown = nativeInspectionForTest(t, []string{"config", "show", "--config", pipeline, "--path", "/whisperx/language", "--format", "json"}) if strings.Contains(shown, "fr") { t.Fatalf("override persisted into later invocation: %s", shown) } after, err := os.ReadFile(pipeline) if err != nil || !bytes.Equal(before, after) { t.Fatal("inspection modified source file") } for _, scope := range []string{"campaign", "session", "party", "all"} { out.Reset() diagnostic.Reset() outcome := Execute(context.Background(), []string{"config", "show", "--scope", scope, "--config", pipeline, "--campaign-file", campaign, "--set", `/whisperx/language="fr"`}, commandkit.Streams{Out: &out, Err: &diagnostic}) if outcome.Status != 2 { t.Fatalf("scope %s accepted unsupported overrides: status=%d diagnostics=%s", scope, outcome.Status, diagnostic.String()) } } } func TestConfigurationComparisonSeparatesCampaignSessionAndRoster(t *testing.T) { _, leftCampaign, leftSession := writeValidConfigFiles(t, t.TempDir()) _, rightCampaign, rightSession := writeValidConfigFiles(t, t.TempDir()) rightBytes, err := os.ReadFile(rightCampaign) if err != nil { t.Fatal(err) } mustWriteTestFile(t, rightCampaign, strings.ReplaceAll(string(rightBytes), "sample-campaign", "other-campaign")) mustWriteTestFile(t, rightSession, "session_id: 2026-05-03\ntitle: Independent right session\ninputs: {audio_dir: ./audio}\n") campaignCfg, err := config.LoadCampaign(rightCampaign) if err != nil { t.Fatal(err) } party, err := config.ResolveParty(rightCampaign, campaignCfg, nil) if err != nil { t.Fatal(err) } mustWriteTestFile(t, party.Source.Path, "schema_version: narratio.party.v1\ncharacters:\n other_character:\n player: {name: Synthetic Player}\n character: {name: Synthetic Character, classes: [{name: ranger}]}\n") leftCfg, err := config.LoadCampaign(leftCampaign) if err != nil { t.Fatal(err) } leftParty, err := config.ResolveParty(leftCampaign, leftCfg, nil) if err != nil { t.Fatal(err) } cases := []struct { scope, path string selectors []string }{ {"campaign", "/campaign_id", []string{"--campaign-file", leftCampaign, "--against-campaign-file", rightCampaign}}, {"session", "/title", []string{"--campaign-file", leftCampaign, "--session", "2026-05-03", "--session-file", leftSession, "--against-campaign-file", rightCampaign, "--against-session", "2026-05-03", "--against-session-file", rightSession}}, {"party", "/characters", []string{"--party-file", leftParty.Source.Path, "--against-campaign-file", rightCampaign}}, {"party", "/characters", []string{"--party-file", leftParty.Source.Path, "--against-party-file", party.Source.Path}}, } for _, test := range cases { var out, diagnostic bytes.Buffer args := append([]string{"config", "diff", "--details", "--scope", test.scope, "--check", "--format", "json"}, test.selectors...) outcome := Execute(context.Background(), args, commandkit.Streams{Out: &out, Err: &diagnostic}) if outcome.Status != 3 || !strings.Contains(out.String(), test.path) { t.Fatalf("scope=%s status=%d output=%s diagnostics=%s", test.scope, outcome.Status, out.String(), diagnostic.String()) } } // An omitted right-side party selector uses normal campaign discovery, never // the left side's exact party file. defaultRoot := filepath.Join(t.TempDir(), "pipeline.yml") mustWriteTestFile(t, defaultRoot, "whisperx: {transcribe_url: https://transcription.example.test/transcribe}\ncampaigns:\n root: "+filepath.Dir(filepath.Dir(rightCampaign))+"\n default_campaign_id: sample-campaign\n") nativeInspectionForTest(t, []string{"config", "diff", "--details", "--scope", "party", "--party-file", leftParty.Source.Path, "--against-config", defaultRoot, "--format", "json"}) } func TestConfigurationComparisonKeepsCredentialValuesHidden(t *testing.T) { const leftSecret, rightSecret = "synthetic-left-comparison-secret", "synthetic-right-comparison-secret" t.Setenv("NARRATIO_COMPARE_LEFT", leftSecret) t.Setenv("NARRATIO_COMPARE_RIGHT", rightSecret) left := filepath.Join(t.TempDir(), "left.yml") right := filepath.Join(t.TempDir(), "right.yml") base := "whisperx: {transcribe_url: https://transcription.example.test/transcribe}\n" mustWriteTestFile(t, left, base+"audita: {credentials: [NARRATIO_COMPARE_LEFT]}\n") mustWriteTestFile(t, right, base+"audita: {credentials: [NARRATIO_COMPARE_RIGHT]}\n") var out, diagnostic bytes.Buffer outcome := Execute(context.Background(), []string{"config", "diff", "--config", left, "--against-config", right, "--check", "--details", "--format", "json"}, commandkit.Streams{Out: &out, Err: &diagnostic}) if outcome.Status != 3 { t.Fatalf("status=%d output=%s diagnostics=%s", outcome.Status, out.String(), diagnostic.String()) } for _, secret := range []string{leftSecret, rightSecret} { if strings.Contains(out.String()+diagnostic.String(), secret) { t.Fatal("comparison exposed resolved credentials") } } }