Migrate item occurrences to native correction while preserving holder semantics

This commit is contained in:
2026-11-22 01:08:02 +00:00
parent 2c1d727232
commit 1fe231b6fb
14 changed files with 519 additions and 486 deletions

View File

@@ -902,6 +902,28 @@ Do not relax existing domain invariants merely to make the migration tests pass.
## Stage 20: Migrate Item Occurrence Extraction
**Status:** Complete. Item occurrences now use native initial/correction requests
through the shared typed producer helper with fixed transcript and names-only
registry materials. Added the same-schema/default-profile correction pair and
static dependencies; removed private completion, prompt/schema registration,
and manifest/fingerprint machinery. Existing private nullable-field mapping,
quantity copying, holder rules, canonical identity, source references, and event
ordering remain unchanged. Unknown selections provide module-authored guidance
before typed assessment, without partial output or invented items. Permissive
terminal output is an explicit codec-valid empty list, not a repaired holder or
ordinary acceptance. Profile/session/execution selections and incoming reuse
ineligibility are preserved. Migrated the holder regression to a native provider
fake with all four typed validators, exact defective-response history, contextual
guidance, final-turn acceptance, and no duplicate final assessment. Added terminal
mode, unknown-item, failed-continuation, structural-failure, cancellation, all-kind,
ordering, and durable nullable-holder cases. Native prompt-pair/holder-principle
and unchanged structural-schema tests run independently in the assets package.
Asset tests/vet/race checks, focused pipeline tests, and `git diff --check` pass.
The extractor and all five occurrence-validator package checks remain blocked at
setup by shared legacy helpers importing old ConfigKit's removed YAML
`plugin/limit`; the new native runtime tests are not claimed passing. Scheduled
dependency cleanup and final assembled verification must execute those tests.
**Goal:** retain the smaller-model holder reliability fixes in the native path.
**Inspect/change:** `internal/modules/dnd/extract/itemoccurrences`, associated